grkvlt commented on a change in pull request #1144:
URL: https://github.com/apache/brooklyn-server/pull/1144#discussion_r570182730
##########
File path:
core/src/main/java/org/apache/brooklyn/util/core/osgi/BundleMaker.java
##########
@@ -269,7 +269,8 @@ private void writeZipEntriesFromFile(ZipOutputStream zout,
File existingZip, Pre
@Deprecated
public Bundle installBundle(File f, boolean start) {
try {
- Bundle b = Osgis.install( framework, "file://"+f.getAbsolutePath()
);
+
+ Bundle b = Osgis.install( framework, f.toURI().toString() );
Review comment:
removed
##########
File path:
core/src/test/java/org/apache/brooklyn/core/config/external/PropertiesFileExternalConfigSupplierTest.java
##########
@@ -68,11 +68,6 @@ public void testFromPropertiesJavaFileUrl() throws Exception
{
doTestFromProperties(f -> f.toURI().toString());
}
- @Test
- public void testFromPropertiesTwoSlashAndPathUrl() throws Exception {
Review comment:
reinserted
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
