ahgittin commented on code in PR #1399:
URL: https://github.com/apache/brooklyn-server/pull/1399#discussion_r1195385222
##########
camp/camp-brooklyn/src/test/java/org/apache/brooklyn/camp/brooklyn/WorkflowYamlTest.java:
##########
@@ -1315,4 +1314,79 @@ public void
testAddPolicyWithDslFromDeployableBlueprint() throws Exception {
EntityAsserts.assertAttributeEquals(entity,
Sensors.newSensor(Object.class, "result"), "yes");
}
+ @Test
Review Comment:
any test (such as this) that actually performs SSH should be marked as
`@Test(groups="Integration")` as unit tests shouldn't assume the ability to
`ssh localhost`
alternatively it a MockSshLocation can be used (add something like
`mock-location` to catalog and pass it)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@brooklyn.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
