ahgittin commented on PR #1399:
URL: https://github.com/apache/brooklyn-server/pull/1399#issuecomment-1549958350
looks good.
some of the tests need tidying.
the test failure reported is
```
testWorkflowLogging(org.apache.brooklyn.core.workflow.WorkflowBasicTest)
Time elapsed: 0.064 sec <<< FAILURE!
java.lang.AssertionError: null: lists don't have the same size expected [8]
but found [11]
at
org.apache.brooklyn.core.workflow.WorkflowBasicTest.testWorkflowLogging(WorkflowBasicTest.java:381)
```
which is almost certainly unrelated. i think i've seen it before. not sure
why it happens occasionally (nice to fix that but not relevant here.)
merge after minor test fixes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@brooklyn.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
