Github user aledsage commented on a diff in the pull request:
https://github.com/apache/incubator-brooklyn/pull/48#discussion_r14704065
--- Diff:
software/base/src/main/java/brooklyn/entity/software/http/HttpRequestSensor.java
---
@@ -0,0 +1,63 @@
+package brooklyn.entity.software.http;
+
+import brooklyn.config.ConfigKey;
+import brooklyn.entity.basic.ConfigKeys;
+import brooklyn.entity.basic.EntityLocal;
+import brooklyn.entity.effector.AddSensor;
+import brooklyn.event.AttributeSensor;
+import brooklyn.event.feed.http.HttpFeed;
+import brooklyn.event.feed.http.HttpPollConfig;
+import brooklyn.event.feed.http.HttpValueFunctions;
+import brooklyn.util.config.ConfigBag;
+import brooklyn.util.time.Duration;
+import com.google.common.base.Functions;
+import com.google.common.base.Preconditions;
+import org.slf4j.LoggerFactory;
+
+import java.util.Map;
+
+/**
+ * Configurable {@link brooklyn.entity.proxying.EntityInitializer} which
adds an HTTP sensor feed to retrieve the
+ * <code>JSONObject</code> from a JSON response in order to populate the
sensor with the indicated <code>name</code>.
+ */
+// generics introduced here because we might support a configurable
'targetType` parameter in future,
+// with automatic casting (e.g. for ints); this way it remains compatible
+public final class HttpRequestSensor<T extends String> extends
AddSensor<String, AttributeSensor<String>> {
--- End diff --
Is `<T extends String>` necessary? `String` is final, so nothing will ever
extend it. You could use <T extends CharSequence>` or just remove the T? Or use
a basic `Object` if it might be automatically converted at some point (not sure
about that last option though)?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
