Github user aledsage commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/48#issuecomment-48457554
Hi @mbarrientos thanks for contributing!
First, have you signed a CLA with apache? If not, could you fill in and
submit this form please to apache - http://www.apache.org/licenses/icla.txt
I hadn't come across jsonPath before - looks very useful. How wide spread
is its use, and how much has it become a standard? (@ahgittin any comments on
that?)
The new dependencies look small and are apache 2 licensed, so I'm fine with
us adding those.
@mbarrientos can you look at adding tests to `JsonFunctionsTest` like those
I suggested in the comment, and fixing the couple of problems (NPE and
ClassCastException, depending on what is in the json). Then I'd be happy to
merge.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
