[
https://issues.apache.org/jira/browse/BROOKLYN-129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14292047#comment-14292047
]
ASF GitHub Bot commented on BROOKLYN-129:
-----------------------------------------
GitHub user michaeldye opened a pull request:
https://github.com/apache/incubator-brooklyn/pull/471
fixed BROOKLYN-129: brooklyn.util.net.Urls.mergePaths(String... items)
doesn't filter null values
Fix for [BROOKLYN-129](https://issues.apache.org/jira/browse/BROOKLYN-129):
filter nulls before iterating through path parts.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/michaeldye/incubator-brooklyn bug/BROOKLYN-129
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-brooklyn/pull/471.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #471
----
commit 0175b95b0748ece05da3471559dac11e534d422b
Author: michaeldye <[email protected]>
Date: 2015-01-26T16:35:08Z
fixed BROOKLYN-129: brooklyn.util.net.Urls.mergePaths(String... items)
doesn't filter null values
----
> brooklyn.util.net.Urls.mergePaths(String... items) doesn't filter null values
> -----------------------------------------------------------------------------
>
> Key: BROOKLYN-129
> URL: https://issues.apache.org/jira/browse/BROOKLYN-129
> Project: Brooklyn
> Issue Type: Bug
> Affects Versions: 0.7.0-M2
> Reporter: michael dye
> Fix For: 0.7.0-M2
>
> Original Estimate: 0.5h
> Remaining Estimate: 0.5h
>
> brooklyn.util.net.Urls.mergePaths(String... items) iterates over given array
> of paths and merges them, including null values. In some cases, this can lead
> to later evaluation of paths like "null/foo.tar.gz". Logging from error
> encountered while deploying from a Chef recipe:
> {noformat}
> 2015-01-20 20:55:31,652 WARN Error invoking start at
> BasicApplicationImpl{id=wjm4Zaws}: Error invoking start at
> BasicApplicationImpl{id=wjm4Zaws}: Error invoking start at
> ChefEntityImpl{id=AfLQVhJO}: SSH task ended with exit code 2 when 0 was
> required, in Task[ssh: extracting archive:hEupCHeQ]: extracting archive
> ...
> cd /root/brooklyn-managed-processes/installs/chef/tmp-brooklyn_doc_gen-ZWet
> tar xvfz null/brooklyn_doc_gen.tar.gz
> rm null/brooklyn_doc_gen.tar.gz
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
