[ 
https://issues.apache.org/jira/browse/BROOKLYN-129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14293470#comment-14293470
 ] 

ASF GitHub Bot commented on BROOKLYN-129:
-----------------------------------------

Github user sjcorbett commented on the pull request:

    https://github.com/apache/incubator-brooklyn/pull/471#issuecomment-71644193
  
    _Should_ it filter nulls? It strikes me as an error of the caller and 
something that would be quite surprising in practice. What is the context of 
the original error in BROOKLYN-129?


> brooklyn.util.net.Urls.mergePaths(String... items) doesn't filter null values
> -----------------------------------------------------------------------------
>
>                 Key: BROOKLYN-129
>                 URL: https://issues.apache.org/jira/browse/BROOKLYN-129
>             Project: Brooklyn
>          Issue Type: Bug
>    Affects Versions: 0.7.0-M2
>            Reporter: michael dye
>             Fix For: 0.7.0-M2
>
>   Original Estimate: 0.5h
>  Remaining Estimate: 0.5h
>
> brooklyn.util.net.Urls.mergePaths(String... items) iterates over given array 
> of paths and merges them, including null values. In some cases, this can lead 
> to later evaluation of paths like "null/foo.tar.gz". Logging from error 
> encountered while deploying from a Chef recipe:
> {noformat}
> 2015-01-20 20:55:31,652 WARN  Error invoking start at 
> BasicApplicationImpl{id=wjm4Zaws}: Error invoking start at 
> BasicApplicationImpl{id=wjm4Zaws}: Error invoking start at 
> ChefEntityImpl{id=AfLQVhJO}: SSH task ended with exit code 2 when 0 was 
> required, in Task[ssh: extracting archive:hEupCHeQ]: extracting archive
> ...
> cd /root/brooklyn-managed-processes/installs/chef/tmp-brooklyn_doc_gen-ZWet
> tar xvfz null/brooklyn_doc_gen.tar.gz
> rm null/brooklyn_doc_gen.tar.gz
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to