Github user andreaturli commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/705#issuecomment-114405734
@ahgittin I think your analysis is very good and complete!
Personally I think jclouds needs some clean up in this area: the generic
`TemplateOptions` contains `networks` so I think for this needs to be used in
most of the cases, instead of adding a custom option.
There are already TODOs or @deprecated in the code so it is ongoing.
a couple of comments:
- Cloudstack uses custom `securityGroupIds` and `networkIds` not the
generic `networks`
- Openstack Nova uses `securityGroupNames` which is marked as @deprecated
(suggests to use `groups` which is maybe even more confusing)
- `Azure` supports the custom `networkSecurityGroupName`
so maybe we should warn the Openstack, Cloudstack and Azure users as you
did for SoftLayer.
- `GCE` seems the only one using `templateOptions.networks()` correctly
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
