Github user sjcorbett commented on a diff in the pull request:
https://github.com/apache/incubator-brooklyn/pull/686#discussion_r35914657
--- Diff:
core/src/main/java/brooklyn/entity/rebind/PeriodicDeltaChangeListener.java ---
@@ -494,5 +496,8 @@ public synchronized void onChanged(BrooklynObject
instance) {
public PersistenceExceptionHandler getExceptionHandler() {
return exceptionHandler;
}
-
+
+ protected boolean shouldLogCheckpoint() {
+ return (checkpointLogCount.get() < 5) || (checkpointLogCount.get()
% 1000 == 0);
--- End diff --
Did you intend to use incrementAndGet? Nothing increments the counters at
the moment so they'll always be 0.
Also suggest getting the value of the integer once so we don't pay
synchronisation penalty twice.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
