Github user sjcorbett commented on a diff in the pull request:
https://github.com/apache/incubator-brooklyn/pull/686#discussion_r35916018
--- Diff:
core/src/main/java/brooklyn/entity/rebind/PeriodicDeltaChangeListener.java ---
@@ -383,7 +385,7 @@ protected void persistNowInternal(boolean
alreadyHasMutex) {
deltaCollector = new DeltaCollector();
}
- if (LOG.isDebugEnabled()) LOG.debug("Checkpointing delta of
memento: "
+ if (shouldLogCheckpoint() && LOG.isDebugEnabled())
LOG.debug("Checkpointing delta of memento: "
--- End diff --
Swap the order of the if conditions for cheaper short-circuiting when
`isDebugEnabled` is false.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
