GitHub user ahgittin opened a pull request:
https://github.com/apache/incubator-brooklyn/pull/844
completes the org.apache-fication - PREVIEW
and tries to give nicer package structure esp in core in the process
worth opening in the IDE and looking around, to see if you like where
things are. it's hard to make it perfect (and not worth a huge amount of
time), so i made some pragmatic compromises in places, though i'm open to it
being improved.
the main compromise was for packages we expect to be subpackaged a lot, i
moved the project name afterwards (except for api) or sometimes dropped it if
there's a clear primary home and the project name would be cumbersome, so we
have
api/ - o.a.b.api.entity
core/ - o.a.b.entity.core
software/base/ - o.a.b.entity.java
anything else makes it really awkward to avoid split packages imho. btw i
think this goes pretty far to fixing the split packages.
personally i like the feel of it when moving around the IDE. how
liberating to be able to do this!
HOWEVER tests are still FAILING - wanted to get this out for preview. the
test fixes shouldn't be hard, i'll finish them tomorrow.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ahgittin/incubator-brooklyn 162-refactor
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-brooklyn/pull/844.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #844
----
commit bc509036738704419814ce972b52958fb5ace797
Author: Alex Heneveld <[email protected]>
Date: 2015-08-18T19:20:05Z
BROOKLYN-162 - refactoring core, applying org.apache package prefix and
grouping more sensibly; also restructuring api package similarly
commit d326759c5508c6767b2780fcb29156150ec0a7e8
Author: Alex Heneveld <[email protected]>
Date: 2015-08-18T20:14:34Z
BROOKLYN-162 - apply org.apache package prefix to policy project (a few
outstanding items)
commit 36db8c7671eb192e988219c5c1d66e380b0e6df5
Author: Alex Heneveld <[email protected]>
Date: 2015-08-18T21:12:56Z
BROOKLYN-162 - apply org.apache package prefix to software-base, tidying
package names, and moving a few sensory things to core
commit 598c8ec06febe56260a293a6caca69175c271227
Author: Alex Heneveld <[email protected]>
Date: 2015-08-18T21:38:46Z
BROOKLYN-162 - jclouds last few package prefixes needed, and tidy in core
and elsewhere related (or observed in the process)
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
