Github user aledsage commented on a diff in the pull request:
https://github.com/apache/incubator-brooklyn/pull/906#discussion_r39839107
--- Diff:
software/base/src/test/java/org/apache/brooklyn/entity/software/base/lifecycle/WinRmExecuteHelperUnitTest.java
---
@@ -0,0 +1,62 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.brooklyn.entity.software.base.lifecycle;
+
+import
org.apache.brooklyn.entity.software.base.DoNothingWinRmSoftwareProcessDriver;
+import org.apache.brooklyn.test.Asserts;
+import org.testng.annotations.Test;
+
+import java.util.Map;
+
+import static org.mockito.Mockito.any;
+import static org.mockito.Mockito.mock;
+import static org.mockito.Mockito.when;
+
+public class WinRmExecuteHelperUnitTest {
+ private static final String NON_ZERO_CODE_COMMAND = "false";
+
+ @Test
+ public void testZeroExitCode() {
+ DoNothingWinRmSoftwareProcessDriver nativeWindowsScriptRunner =
mock(DoNothingWinRmSoftwareProcessDriver.class);
+
+ WinRmExecuteHelper scriptHelper = new
WinRmExecuteHelper(nativeWindowsScriptRunner, "test-zero-code-task");
+ Asserts.assertTrue(scriptHelper.executeInternal() == 0,
"WinRmExecuteHelper doesn't return zero code");
+ }
+
+ @Test
+ public void testNonZeroExitCode() {
+ DoNothingWinRmSoftwareProcessDriver nativeWindowsScriptRunner =
mock(DoNothingWinRmSoftwareProcessDriver.class);
+ when(nativeWindowsScriptRunner.executeCommand(any(Map.class),
any(String.class), any(String.class), any(String.class),
any(Boolean.class))).thenReturn(1);
+
+ WinRmExecuteHelper scriptHelper = new
WinRmExecuteHelper(nativeWindowsScriptRunner, "test-zero-code-task")
+ .setCommand(NON_ZERO_CODE_COMMAND);
+ Asserts.assertTrue(scriptHelper.executeInternal() != 0,
"WinRmExecuteHelper return zero code for non-zero code task");
+ }
+
+ @Test(expectedExceptions = IllegalStateException.class)
+ public void testNonZeroExitCodeException() {
--- End diff --
This method's body looks the same as `testNonZeroExitCode`. Given you are
actually asserting with `expectedExceptions` above, then strip out the extra
code (e.g. the `assertTrue` at the end of this method).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
