Github user aledsage commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/906#issuecomment-141406660
I'm concerned that we've made the code more complicated by adding the
`WinRmExecuteHelper.java`, but without it having the same functionality as the
ssh version (e.g. it's impossible to get the stdout/stderr back when you use
it).
We don't actually need the `WinRmExecuteHelper` currently (because things
are called from yaml) so we can defer that, but if we're deferring it then it
feels like we could have deferred adding this class just now.
With this change, we are much of the way there to having the more powerful
execution helper, but we have lost functionality compared to where we were
before (i.e. you can't get the stdout/stderr if writing Java).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
