Github user robertgmoss commented on a diff in the pull request:
https://github.com/apache/incubator-brooklyn/pull/919#discussion_r40929738
--- Diff:
core/src/main/java/org/apache/brooklyn/enricher/stock/Enrichers.java ---
@@ -676,6 +681,62 @@ public String toString() {
.toString();
}
}
+
+ protected abstract static class AbstractReducerBuilder<S, T, B extends
AbstractReducerBuilder<S, T, B>> extends AbstractEnricherBuilder<B> {
+ protected AttributeSensor<T> publishing;
+ protected Entity fromEntity;
+ protected List<AttributeSensor<S>> reducing;
+ protected Function<List<S>, T> computing;
+ protected String functionName;
+ private Map<String, Object> parameters;
+
+ public AbstractReducerBuilder(Class<? extends Reducer<S, T>>
clazz, List<AttributeSensor<S>> val) {
--- End diff --
This would be inconsistent with the other uses throughout, and could cause
confusion. I'm inclined to say that this should be done in another PR.
Moreover, this is a protected class and not public. Perhaps a discussion on
the mailing list about whether this should be adopted widely.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
