Github user neykov commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/919#issuecomment-145535770
All the comments I have are in bike-shedding land, so feel free to ignore.
Here are some more:
* From a user perspective I would prefer to use a single `Reducer` which
knows how to load any transformation alias (as opposed to having to look up
which implementation does which alias).
* When working with sensors (especially in yaml land) you never know what
the type of the input sensor(s) will be even if the interface is typed in Java.
So as a rule of thumb it's nice to `coerce` to the required type instead of
forcing the sensor to be of the required type. This would also alleviate the
need for all the XXXStringReducer alternatives.
Looks good and can be merged as is.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
