GitHub user tbouron opened a pull request:

    https://github.com/apache/incubator-brooklyn/pull/949

    Add support for correct configkey conversion from the app wizard UI

    Right now, the app wizard modal pass all additional configurations as 
`String`. If the entities have configkey with different types, an array of 
integers for example, Brooklyn will fail right after hitting the `Finish` 
button because it won't be able to convert `"[]"` as an array.
    
    This will correctly convert string value, entered within the app wizard, 
into their corresponding Javascript type. For instance:
    - `[1,2,3,4]` will be converted as a JS `Array` that contains 1, 2, 3 and 4 
integers (`Number` type)
    - `{"test": true}` will be converted as a JS `Object` containing the field 
`test` with the boolean value `true`
    - `true` will be converted as a `Boolean`
    - `0.123456` will be converted as a `Number`
    
    If the conversion fails, it will fallback to the previous implementation 
which is taking the value as a `String`.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/tbouron/incubator-brooklyn master

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-brooklyn/pull/949.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #949
    
----
commit 204e87c5170f595951d59c16f7864fc2a8d98624
Author: Thomas Bouron <[email protected]>
Date:   2015-10-12T15:04:13Z

    Add support for correct configkey conversion from the app wizard UI

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to