Github user tbouron commented on a diff in the pull request:

    https://github.com/apache/incubator-brooklyn/pull/949#discussion_r42224303
  
    --- Diff: 
usage/jsgui/src/main/webapp/assets/js/view/application-add-wizard.js ---
    @@ -85,6 +85,13 @@ define([
             if (entity.config && _.size(entity.config)) 
result["brooklyn.config"] = entity.config;
             return result;
         }
    +    function getConvertedConfigValue(value) {
    +        try {
    +            return $.parseJSON(value);
    +        } catch (e) {
    +            return value;
    --- End diff --
    
    @neykov The example you gave seems very convoluted. If you want to pass a 
list from a `String`, chances are you will use a comma-separated list (i.e. 
`1,2,3,4`) which is simpler to parse than `[1, 2, 3, 4]`, don't you think? This 
is actually what my client does, he uses comma-separated string to pass a list 
of options.
    
    Now, I do get you point about the parsing but I think this is a use case 
that we will never reach because of this PR and its ability to pass a real 
array.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to