Github user neykov commented on a diff in the pull request:

    https://github.com/apache/incubator-brooklyn/pull/949#discussion_r42227272
  
    --- Diff: 
usage/jsgui/src/main/webapp/assets/js/view/application-add-wizard.js ---
    @@ -85,6 +85,13 @@ define([
             if (entity.config && _.size(entity.config)) 
result["brooklyn.config"] = entity.config;
             return result;
         }
    +    function getConvertedConfigValue(value) {
    +        try {
    +            return $.parseJSON(value);
    +        } catch (e) {
    +            return value;
    --- End diff --
    
    I would say specific, not convoluted - the behaviour for String config keys 
changes (i.e. getting objects instead, stripping quotes, etc.).
    
    I don't mind merging as is as this can easily be amended in a future PR.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to