Github user neykov commented on a diff in the pull request:

    https://github.com/apache/incubator-brooklyn/pull/980#discussion_r42751206
  
    --- Diff: 
software/base/src/main/java/org/apache/brooklyn/entity/machine/MachineInitTasks.java
 ---
    @@ -98,6 +101,7 @@ protected void openIptablesImpl(Iterable<Integer> 
inboundPorts, SshMachineLocati
                 log.info("Opening ports in iptables for {} at {}", entity(), 
machine);
     
                 List<String> iptablesRules = Lists.newArrayList();
    +            String iptablesInstallCommands = "";
    --- End diff --
    
    No point in creating a task and ssh-ing if the command is empty, better set 
it to null and don't do an ssh call in this case at all.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to