Github user neykov commented on a diff in the pull request:
https://github.com/apache/incubator-brooklyn/pull/980#discussion_r42751715
--- Diff:
software/base/src/main/java/org/apache/brooklyn/entity/machine/MachineInitTasks.java
---
@@ -75,13 +72,19 @@ public Void call() {
/**
* Returns a queued {@link Task} which stops iptables on the given
machine.
*/
- public Task<Void> stopIptablesAsync(final SshMachineLocation machine) {
- return DynamicTasks.queue("stop iptables", new Callable<Void>() {
- public Void call() {
- stopIptablesImpl(machine);
- return null;
- }
- });
+ public ProcessTaskWrapper<Integer> stopIptablesAsync(final
SshMachineLocation machine) {
--- End diff --
Change all methods to return `Task` instead of `ProcessTaskWrapper`, use
`.asTask()` to get the task from the `queue` return value.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
