Github user neykov commented on a diff in the pull request:
https://github.com/apache/incubator-brooklyn/pull/993#discussion_r43630612
--- Diff:
usage/camp/src/test/java/org/apache/brooklyn/camp/brooklyn/catalog/CatalogYamlRebindTest.java
---
@@ -198,13 +191,7 @@ protected void
runRebindWithCatalogAndApp(RebindWithCatalogTestMode mode) throws
addCatalogItems(String.format(locCatalogFormat,
locVersion));
break;
case STRIP_DEPRECATION_AND_ENABLEMENT_FROM_CATALOG_ITEM:
- //Make sure that the flags are actually removed from the
XML instead of still being there with false values
- appItem.setDeprecated(true);
- appItem.setDisabled(true);
- mgmt().getCatalog().persist(appItem);
- locItem.setDisabled(true);
- locItem.setDeprecated(true);
- mgmt().getCatalog().persist(locItem);
+ // nothing here -- but below we rebind with these fields
removed to ensure that we can rebind
--- End diff --
Should keep these. They confirm that the disabled/deprecated elements are
removed from the XML. Prior the adding them the test was successfully passing,
but not testing anything because the elements weren't actually removed, so the
default values of `false` remained.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
