Github user ahgittin commented on a diff in the pull request:

    https://github.com/apache/incubator-brooklyn/pull/993#discussion_r43640500
  
    --- Diff: 
core/src/main/java/org/apache/brooklyn/core/catalog/internal/JavaCatalogToSpecTransformer.java
 ---
    @@ -68,11 +73,11 @@ public boolean accepts(String planType) {
         public <T, SpecT extends AbstractBrooklynObjectSpec<? extends T, 
SpecT>> SpecT createCatalogSpec(
                 CatalogItem<T, SpecT> item, Set<String> encounteredTypes) 
throws PlanNotRecognizedException {
             if (item.getJavaType() != null) {
    -            log.warn("Deprecated functionality (since 0.9.0). Using 
old-style xml catalog items with java type attribute for " + item);
                 Class<?> type;
                 try {
    -                type = 
mgmt.getCatalogClassLoader().loadClass(item.getJavaType());
    -            } catch (ClassNotFoundException e) {
    +                type = CatalogUtils.newClassLoadingContext(mgmt, 
item).loadClass(item.getJavaType());
    --- End diff --
    
    thanks -- that clears it up, added comments to remind us for later


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to