[
https://issues.apache.org/jira/browse/BROOKLYN-190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14985320#comment-14985320
]
ASF GitHub Bot commented on BROOKLYN-190:
-----------------------------------------
Github user neykov commented on a diff in the pull request:
https://github.com/apache/incubator-brooklyn/pull/997#discussion_r43634926
--- Diff:
usage/launcher/src/main/java/org/apache/brooklyn/launcher/BrooklynWebServer.java
---
@@ -379,13 +381,25 @@ public synchronized void start() throws Exception {
throw new IllegalStateException("Unable to provision port
for web console (wanted "+portRange+")");
}
- server = new Server();
- final Connector connector;
+
+ // use a nice name in the thread pool (otherwise this is exactly
the same as Server defaults)
+ QueuedThreadPool threadPool = new QueuedThreadPool();
+
threadPool.setName("brooklyn-jetty-server-"+actualPort+"-"+threadPool.getName());
+
+ server = new Server(threadPool);
+ final ServerConnector connector;
+
if (getHttpsEnabled()) {
- connector = new
SslSelectChannelConnector(createContextFactory());
+ HttpConfiguration sslHttpConfig = new HttpConfiguration();
+ sslHttpConfig.setSecureScheme("https");
+ sslHttpConfig.setSecurePort(actualPort);
+
+ SslContextFactory sslContextFactory = createContextFactory();
+ connector = new ServerConnector(server, new
SslConnectionFactory(sslContextFactory, "http/1.1"), new
HttpConnectionFactory(sslHttpConfig));
--- End diff --
Use HttpVersion.HTTP_1_1.asString().
> Upgrade to Jetty9
> -----------------
>
> Key: BROOKLYN-190
> URL: https://issues.apache.org/jira/browse/BROOKLYN-190
> Project: Brooklyn
> Issue Type: Improvement
> Affects Versions: 0.8.0, 0.9.0
> Reporter: Ciprian Ciubotariu
> Assignee: Ciprian Ciubotariu
> Priority: Minor
> Fix For: 0.9.0
>
>
> According to [1] jetty9 is now the stable version.
> In relation to BROOKLYN-183, current stable pax-web 4.x series also support
> Jetty9 (although I believe it can be used with Jetty8 as well). However,
> migrating Brooklyn to a more current Jetty version seems preferable.
> [1] http://www.eclipse.org/jetty/documentation/current/what-jetty-version.html
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
