[
https://issues.apache.org/jira/browse/BROOKLYN-190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14985518#comment-14985518
]
ASF GitHub Bot commented on BROOKLYN-190:
-----------------------------------------
Github user neykov commented on a diff in the pull request:
https://github.com/apache/incubator-brooklyn/pull/997#discussion_r43650051
--- Diff:
usage/launcher/src/test/java/org/apache/brooklyn/launcher/BrooklynWebServerTest.java
---
@@ -146,11 +146,13 @@ public void verifyHttpsFromConfig() throws Exception {
@Test
public void verifyHttpsCiphers() throws Exception {
brooklynProperties.put(BrooklynWebConfig.HTTPS_REQUIRED, true);
- brooklynProperties.put(BrooklynWebConfig.TRANSPORT_PROTOCOLS,
"XXX");
- brooklynProperties.put(BrooklynWebConfig.TRANSPORT_CIPHERS, "XXX");
--- End diff --
But why remove the properties? The test is meant to confirm that the
properties are actually used to configure the web server.
Having this pass now suggests that the test is not working as expected
though.
> Upgrade to Jetty9
> -----------------
>
> Key: BROOKLYN-190
> URL: https://issues.apache.org/jira/browse/BROOKLYN-190
> Project: Brooklyn
> Issue Type: Improvement
> Affects Versions: 0.8.0, 0.9.0
> Reporter: Ciprian Ciubotariu
> Assignee: Ciprian Ciubotariu
> Priority: Minor
> Fix For: 0.9.0
>
>
> According to [1] jetty9 is now the stable version.
> In relation to BROOKLYN-183, current stable pax-web 4.x series also support
> Jetty9 (although I believe it can be used with Jetty8 as well). However,
> migrating Brooklyn to a more current Jetty version seems preferable.
> [1] http://www.eclipse.org/jetty/documentation/current/what-jetty-version.html
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
