Github user ahgittin commented on a diff in the pull request:
https://github.com/apache/incubator-brooklyn/pull/1017#discussion_r45048688
--- Diff:
core/src/test/java/org/apache/brooklyn/core/catalog/internal/SpecParameterInMetaTest.java
---
@@ -43,18 +49,40 @@
public class SpecParameterInMetaTest {
private ManagementContext mgmt;
private BrooklynCatalog catalog;
- private String spec;
+ private String specId;
@BeforeMethod(alwaysRun=true)
public void setUp() {
mgmt = LocalManagementContextForTests.newInstanceWithOsgi();
catalog = mgmt.getCatalog();
- spec =
TestToSpecTransformer.registerSpec(EntitySpec.create(BasicEntity.class));
+ StaticTypePlanTransformer.forceInstall();
+ PlanToSpecFactory.forceAvailable(TestToSpecTransformer.class,
JavaCatalogToSpecTransformer.class);
+ specId =
StaticTypePlanTransformer.registerSpec(EntitySpec.create(BasicEntity.class));
}
+ @AfterMethod(alwaysRun=true)
+ public void tearDown() {
+ StaticTypePlanTransformer.clearForced();
+ PlanToSpecFactory.clearForced();
+ }
+
+ @Test
+ public void testCanRetrieveWithNew() {
+ AbstractBrooklynObjectSpec<?, ?> spec =
mgmt.getTypeRegistry().createSpecFromPlan(null, specId, null, null);
+ Assert.assertNotNull(spec);
+ }
+
+ // it's not actually added to the catalog; probably it would be
cleaner if it is;
--- End diff --
I don't quite follow. In general if a plan refers to a type, I'd expect
that type in the catalog (or a java class). While a transformer can define
other rules for instantiating types, I'm not sure that's good practice.
(Except it's okay for tests.)
(have captured this discussion in the code)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
