Github user aledsage commented on a diff in the pull request:

    https://github.com/apache/incubator-brooklyn/pull/1043#discussion_r45329049
  
    --- Diff: 
usage/jsgui/src/test/java/org/apache/brooklyn/rest/jsgui/BrooklynJavascriptGuiLauncher.java
 ---
    @@ -49,7 +49,7 @@
         public static void main(String[] args) throws Exception {
             // NOTE: When running Brooklyn from an IDE (i.e. by launching 
BrooklynJavascriptGuiLauncher.main())
             // you will need to ensure that the working directory is set to 
the jsgui folder. For IntelliJ,
    -        // set the 'Working directory' of the Run/Debug Configuration to 
$MODULE_DIR/../jsgui.
    +        // set the 'Working directory' of the Run/Debug Configuration to 
$MODULE_DIR$/../jsgui.
    --- End diff --
    
    Not sure I follow why you make this change. The previous syntax in the 
comment was assuming that MODULE_DIR was an environment variable, so why 
surround it with a `$` on each side?
    
    But I don't care :-)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to