Github user sjcorbett commented on a diff in the pull request:
https://github.com/apache/incubator-brooklyn/pull/1043#discussion_r45343190
--- Diff:
core/src/main/java/org/apache/brooklyn/util/core/task/ScheduledTask.java ---
@@ -84,12 +99,15 @@ public ScheduledTask(Map flags, Callable<Task<?>>
taskFactory) {
delay = Duration.of(elvis(flags.remove("delay"), 0));
period = Duration.of(elvis(flags.remove("period"), null));
maxIterations = elvis(flags.remove("maxIterations"), null);
+ Object cancelFlag = flags.remove("cancelOnException");
+ cancelOnException = cancelFlag == null ||
Boolean.TRUE.equals(cancelFlag);
--- End diff --
Yes, I assume callers are going to do the right thing. They also have the
option of calling `cancelOnException(boolean)` if they like the strongly-typed
side of life.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
