[
https://issues.apache.org/jira/browse/BROOKLYN-166?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15029725#comment-15029725
]
ASF GitHub Bot commented on BROOKLYN-166:
-----------------------------------------
Github user ahgittin commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/865#issuecomment-160105246
the following issues are still outstanding:
* check/fix `overflow-x: scroll` for textareas, likely others depend on
this style you've removed --
https://github.com/apache/incubator-brooklyn/pull/865/files#diff-2c00b2e9ba84934a94b937199763e780L28
* 3rd party deps into `libs/` like the others, not in `lib/` and `addons/`
(or say why not)
* revert auto-scanning of classpath for REST API; it significantly
increases startup time and typically we don't want it (you can trigger a scan
by POSTing a suitable catalog.bom if you need to, or add those explicit items
you wish to have); if you think it should be there, please give more details --
https://github.com/apache/incubator-brooklyn/pull/865/files#diff-b8eba103a5475b653aaba9dd4fe8827cR55
new ones:
* UI does not run: `:8081/assets/js/router.js:39 Uncaught TypeError:
serverStatus.addCallback is not a function` (and we get the same error with JS
jasmine tests: `[ERROR] java.lang.RuntimeException:
org.openqa.selenium.WebDriverException:
com.gargoylesoftware.htmlunit.ScriptException: Wrapped
com.gargoylesoftware.htmlunit.ScriptException: Wrapped
com.gargoylesoftware.htmlunit.ScriptException: TypeError: Cannot find function
addCallback in object [object Object].
(http://localhost:57004/src/js/router.js#39)`)
* license metadata needs to be added to `overrides.yaml` (the `LICENSE`
files are autogenerated from this) -
https://github.com/apache/incubator-brooklyn/pull/865/files#diff-001a0bdd771ea5cf50f47cd08ce6a0dcR356
ability to test is limited by the above issues!
> Use a feature rich yaml editor
> ------------------------------
>
> Key: BROOKLYN-166
> URL: https://issues.apache.org/jira/browse/BROOKLYN-166
> Project: Brooklyn
> Issue Type: Improvement
> Reporter: Hadrian Zbarcea
> Fix For: 0.8.0
>
>
> Brooklyn would benefit from a feature rich editor that would give a user more
> feedback on what is possible when editing a camp blueprint.
> The best candidate is imho codemirror, used by many apps, including swagger.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
