[ 
https://issues.apache.org/jira/browse/BROOKLYN-166?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15029750#comment-15029750
 ] 

ASF GitHub Bot commented on BROOKLYN-166:
-----------------------------------------

Github user ahgittin commented on the pull request:

    https://github.com/apache/incubator-brooklyn/pull/865#issuecomment-160108239
  
    i've fixed the problem with startup.  now looks much better, and tests work.
    
    however:
    * i thought "Editor" was going to be called "Composer"
    * when using the pop-up wizard there should be a flow by which i can go to 
the composer populated with the YAML for what i've built (this is what the 
`preview` button typically does; maybe we should have the preview enabled even 
on the first step of the wizard if i have something selected)
    * on catalog page, add, if i click "yaml" to add a yaml catalog item, 
nothing happens -- i think it should take me to the blueprint editor, perhaps 
pre-populated with a sample item a la 
http://brooklyn.apache.org/v/latest/ops/catalog/index.html (NB catalog has a 
different syntax than normal deployments; it also accepts the normal deployment 
syntax), or see below
    * do we want a "Help" button on the composer, e.g. with a dropdown that has 
"insert template blueprint", "insert template catalog addition", "go to online 
documentation"
    * on the editor page what is "Delete" supposed to do?  currently seems to 
do nothing.  perhaps remove?  or comment out with TODO if you think it might do 
something in future.  (i'm not sure it does.)
    * on the editor page the "Run" button doesn't work; it constructs a POST 
but it is malformed
    * no feedback is given after clicking "Run"; on success it should take you 
to the "Applications" tab with the app highlighted (you have the app ID in the 
response code so that should be easy), and on failure it should show a message
    * there should be an "Add to Catalog" button on the editor/composer which 
has same feedback after clicking, taking you to catalog page (same as if you 
clicked the old catalog add yaml button)



> Use a feature rich yaml editor
> ------------------------------
>
>                 Key: BROOKLYN-166
>                 URL: https://issues.apache.org/jira/browse/BROOKLYN-166
>             Project: Brooklyn
>          Issue Type: Improvement
>            Reporter: Hadrian Zbarcea
>             Fix For: 0.8.0
>
>
> Brooklyn would benefit from a feature rich editor that would give a user more 
> feedback on what is possible when editing a camp blueprint.
> The best candidate is imho codemirror, used by many apps, including swagger.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to