Hi, von, thanks for your review, But I am not quite understanding your comments, please help me to verify, thanks
1. NOTICE, you said there is a slight problem, but where ? 2. Copyright for valgrind.h is in LICENSE, line 386, any problem for it? 3. we modified some files from chromium, which is BSD license, BSD is compatible with apache v2. 在 2019/11/19 下午8:06,“Gosling Von”<fengji...@gmail.com> 写入: -1 asc and sha512 signature ok, but NOTICE and LICENSE seems to be a slight problem like the following. Some licenses listed in the LICESE doesn't match my checking path(src/butil/third_party/valgrind/valgrind.h, where is third_party in src tarball?). What’s more, why imported so many test and example files from Chromium, I could not find any corresponding statement in the LICESE file, does it compatible with ASL v2? ***************************************************** Summary ------- Generated at: 2019-11-19T19:47:36+08:00 Notes: 17 Binaries: 6 Archives: 0 Standards: 1192 Apache Licensed: 772 Generated Documents: 0 JavaDocs are generated, thus a license header is optional. Generated files do not require license headers. 415 Unknown Licenses ***************************************************** Files with unapproved licenses: incubator-brpc-0.9.7-rc01/example/auto_concurrency_limiter/dummy_server.port incubator-brpc-0.9.7-rc01/example/auto_concurrency_limiter/settings.flags incubator-brpc-0.9.7-rc01/example/auto_concurrency_limiter/test_case.json incubator-brpc-0.9.7-rc01/example/thrift_extension_c++/README.md incubator-brpc-0.9.7-rc01/example/thrift_extension_c++/echo.thrift incubator-brpc-0.9.7-rc01/java/TBD incubator-brpc-0.9.7-rc01/python/TBD incubator-brpc-0.9.7-rc01/src/brpc/callback.h incubator-brpc-0.9.7-rc01/src/brpc/builtin/pprof_perl.cpp incubator-brpc-0.9.7-rc01/src/brpc/details/tcmalloc_extension.h incubator-brpc-0.9.7-rc01/src/bthread/context.cpp incubator-brpc-0.9.7-rc01/src/bthread/context.h incubator-brpc-0.9.7-rc01/src/bthread/offset_inl.list incubator-brpc-0.9.7-rc01/src/butil/at_exit.cc incubator-brpc-0.9.7-rc01/src/butil/at_exit.h incubator-brpc-0.9.7-rc01/src/butil/atomic_ref_count.h incubator-brpc-0.9.7-rc01/src/butil/atomic_sequence_num.h incubator-brpc-0.9.7-rc01/src/butil/atomicops.h incubator-brpc-0.9.7-rc01/src/butil/atomicops_internals_arm64_gcc.h incubator-brpc-0.9.7-rc01/src/butil/atomicops_internals_arm_gcc.h incubator-brpc-0.9.7-rc01/src/butil/atomicops_internals_atomicword_compat.h incubator-brpc-0.9.7-rc01/src/butil/atomicops_internals_gcc.h incubator-brpc-0.9.7-rc01/src/butil/atomicops_internals_mac.h incubator-brpc-0.9.7-rc01/src/butil/atomicops_internals_mips_gcc.h incubator-brpc-0.9.7-rc01/src/butil/atomicops_internals_tsan.h incubator-brpc-0.9.7-rc01/src/butil/atomicops_internals_x86_gcc.cc incubator-brpc-0.9.7-rc01/src/butil/atomicops_internals_x86_gcc.h incubator-brpc-0.9.7-rc01/src/butil/atomicops_internals_x86_msvc.h incubator-brpc-0.9.7-rc01/src/butil/auto_reset.h incubator-brpc-0.9.7-rc01/src/butil/base64.cc incubator-brpc-0.9.7-rc01/src/butil/base64.h incubator-brpc-0.9.7-rc01/src/butil/base_export.h incubator-brpc-0.9.7-rc01/src/butil/base_paths.cc incubator-brpc-0.9.7-rc01/src/butil/basictypes.h incubator-brpc-0.9.7-rc01/src/butil/big_endian.cc incubator-brpc-0.9.7-rc01/src/butil/big_endian.h incubator-brpc-0.9.7-rc01/src/butil/bits.h incubator-brpc-0.9.7-rc01/src/butil/build_config.h incubator-brpc-0.9.7-rc01/src/butil/cancelable_callback.h incubator-brpc-0.9.7-rc01/src/butil/compiler_specific.h incubator-brpc-0.9.7-rc01/src/butil/cpu.cc incubator-brpc-0.9.7-rc01/src/butil/cpu.h incubator-brpc-0.9.7-rc01/src/butil/crc32c.cc incubator-brpc-0.9.7-rc01/src/butil/crc32c.h incubator-brpc-0.9.7-rc01/src/butil/environment.cc incubator-brpc-0.9.7-rc01/src/butil/environment.h incubator-brpc-0.9.7-rc01/src/butil/file_descriptor_posix.h incubator-brpc-0.9.7-rc01/src/butil/file_util.cc incubator-brpc-0.9.7-rc01/src/butil/file_util.h incubator-brpc-0.9.7-rc01/src/butil/file_util_linux.cc incubator-brpc-0.9.7-rc01/src/butil/file_util_mac.mm incubator-brpc-0.9.7-rc01/src/butil/file_util_posix.cc incubator-brpc-0.9.7-rc01/src/butil/float_util.h incubator-brpc-0.9.7-rc01/src/butil/format_macros.h incubator-brpc-0.9.7-rc01/src/butil/gperftools_profiler.h incubator-brpc-0.9.7-rc01/src/butil/gtest_prod_util.h incubator-brpc-0.9.7-rc01/src/butil/guid.cc incubator-brpc-0.9.7-rc01/src/butil/guid.h incubator-brpc-0.9.7-rc01/src/butil/guid_posix.cc incubator-brpc-0.9.7-rc01/src/butil/hash.cc incubator-brpc-0.9.7-rc01/src/butil/hash.h incubator-brpc-0.9.7-rc01/src/butil/intrusive_ptr.hpp incubator-brpc-0.9.7-rc01/src/butil/lazy_instance.cc incubator-brpc-0.9.7-rc01/src/butil/lazy_instance.h incubator-brpc-0.9.7-rc01/src/butil/location.cc incubator-brpc-0.9.7-rc01/src/butil/location.h incubator-brpc-0.9.7-rc01/src/butil/macros.h incubator-brpc-0.9.7-rc01/src/butil/md5.cc incubator-brpc-0.9.7-rc01/src/butil/md5.h incubator-brpc-0.9.7-rc01/src/butil/move.h incubator-brpc-0.9.7-rc01/src/butil/observer_list.h incubator-brpc-0.9.7-rc01/src/butil/port.h incubator-brpc-0.9.7-rc01/src/butil/rand_util.cc incubator-brpc-0.9.7-rc01/src/butil/rand_util.h incubator-brpc-0.9.7-rc01/src/butil/rand_util_posix.cc incubator-brpc-0.9.7-rc01/src/butil/safe_strerror_posix.cc incubator-brpc-0.9.7-rc01/src/butil/safe_strerror_posix.h incubator-brpc-0.9.7-rc01/src/butil/scoped_clear_errno.h incubator-brpc-0.9.7-rc01/src/butil/scoped_generic.h incubator-brpc-0.9.7-rc01/src/butil/scoped_observer.h incubator-brpc-0.9.7-rc01/src/butil/sha1.h incubator-brpc-0.9.7-rc01/src/butil/sha1_portable.cc incubator-brpc-0.9.7-rc01/src/butil/stl_util.h incubator-brpc-0.9.7-rc01/src/butil/sys_byteorder.h incubator-brpc-0.9.7-rc01/src/butil/type_traits.h incubator-brpc-0.9.7-rc01/src/butil/unique_ptr.h incubator-brpc-0.9.7-rc01/src/butil/version.cc incubator-brpc-0.9.7-rc01/src/butil/version.h incubator-brpc-0.9.7-rc01/src/butil/containers/hash_tables.h incubator-brpc-0.9.7-rc01/src/butil/containers/linked_list.h incubator-brpc-0.9.7-rc01/src/butil/containers/mru_cache.h incubator-brpc-0.9.7-rc01/src/butil/containers/scoped_ptr_hash_map.h incubator-brpc-0.9.7-rc01/src/butil/containers/small_map.h incubator-brpc-0.9.7-rc01/src/butil/containers/stack_container.h incubator-brpc-0.9.7-rc01/src/butil/debug/alias.cc incubator-brpc-0.9.7-rc01/src/butil/debug/alias.h incubator-brpc-0.9.7-rc01/src/butil/debug/asan_invalid_access.cc incubator-brpc-0.9.7-rc01/src/butil/debug/asan_invalid_access.h incubator-brpc-0.9.7-rc01/src/butil/debug/crash_logging.cc incubator-brpc-0.9.7-rc01/src/butil/debug/crash_logging.h incubator-brpc-0.9.7-rc01/src/butil/debug/debugger.cc incubator-brpc-0.9.7-rc01/src/butil/debug/debugger.h incubator-brpc-0.9.7-rc01/src/butil/debug/debugger_posix.cc incubator-brpc-0.9.7-rc01/src/butil/debug/dump_without_crashing.cc incubator-brpc-0.9.7-rc01/src/butil/debug/dump_without_crashing.h incubator-brpc-0.9.7-rc01/src/butil/debug/leak_annotations.h incubator-brpc-0.9.7-rc01/src/butil/debug/leak_tracker.h incubator-brpc-0.9.7-rc01/src/butil/debug/proc_maps_linux.cc incubator-brpc-0.9.7-rc01/src/butil/debug/proc_maps_linux.h incubator-brpc-0.9.7-rc01/src/butil/debug/stack_trace.cc incubator-brpc-0.9.7-rc01/src/butil/debug/stack_trace.h incubator-brpc-0.9.7-rc01/src/butil/debug/stack_trace_posix.cc incubator-brpc-0.9.7-rc01/src/butil/files/dir_reader_fallback.h incubator-brpc-0.9.7-rc01/src/butil/files/dir_reader_linux.h incubator-brpc-0.9.7-rc01/src/butil/files/dir_reader_posix.h incubator-brpc-0.9.7-rc01/src/butil/files/file.cc incubator-brpc-0.9.7-rc01/src/butil/files/file.h incubator-brpc-0.9.7-rc01/src/butil/files/file_enumerator.cc incubator-brpc-0.9.7-rc01/src/butil/files/file_enumerator.h incubator-brpc-0.9.7-rc01/src/butil/files/file_enumerator_posix.cc incubator-brpc-0.9.7-rc01/src/butil/files/file_path.cc incubator-brpc-0.9.7-rc01/src/butil/files/file_path.h incubator-brpc-0.9.7-rc01/src/butil/files/file_path_constants.cc incubator-brpc-0.9.7-rc01/src/butil/files/file_posix.cc incubator-brpc-0.9.7-rc01/src/butil/files/memory_mapped_file.cc incubator-brpc-0.9.7-rc01/src/butil/files/memory_mapped_file.h incubator-brpc-0.9.7-rc01/src/butil/files/memory_mapped_file_posix.cc incubator-brpc-0.9.7-rc01/src/butil/files/scoped_file.cc incubator-brpc-0.9.7-rc01/src/butil/files/scoped_file.h incubator-brpc-0.9.7-rc01/src/butil/files/scoped_temp_dir.cc incubator-brpc-0.9.7-rc01/src/butil/files/scoped_temp_dir.h incubator-brpc-0.9.7-rc01/src/butil/mac/bundle_locations.h incubator-brpc-0.9.7-rc01/src/butil/mac/bundle_locations.mm incubator-brpc-0.9.7-rc01/src/butil/mac/foundation_util.h incubator-brpc-0.9.7-rc01/src/butil/mac/foundation_util.mm incubator-brpc-0.9.7-rc01/src/butil/mac/scoped_cftyperef.h incubator-brpc-0.9.7-rc01/src/butil/mac/scoped_mach_port.cc incubator-brpc-0.9.7-rc01/src/butil/mac/scoped_mach_port.h incubator-brpc-0.9.7-rc01/src/butil/mac/scoped_typeref.h incubator-brpc-0.9.7-rc01/src/butil/memory/aligned_memory.cc incubator-brpc-0.9.7-rc01/src/butil/memory/aligned_memory.h incubator-brpc-0.9.7-rc01/src/butil/memory/linked_ptr.h incubator-brpc-0.9.7-rc01/src/butil/memory/manual_constructor.h incubator-brpc-0.9.7-rc01/src/butil/memory/raw_scoped_refptr_mismatch_checker.h incubator-brpc-0.9.7-rc01/src/butil/memory/ref_counted.cc incubator-brpc-0.9.7-rc01/src/butil/memory/ref_counted.h incubator-brpc-0.9.7-rc01/src/butil/memory/ref_counted_memory.cc incubator-brpc-0.9.7-rc01/src/butil/memory/ref_counted_memory.h incubator-brpc-0.9.7-rc01/src/butil/memory/scoped_array.h incubator-brpc-0.9.7-rc01/src/butil/memory/scoped_open_process.h incubator-brpc-0.9.7-rc01/src/butil/memory/scoped_policy.h incubator-brpc-0.9.7-rc01/src/butil/memory/scoped_ptr.h incubator-brpc-0.9.7-rc01/src/butil/memory/scoped_vector.h incubator-brpc-0.9.7-rc01/src/butil/memory/singleton.cc incubator-brpc-0.9.7-rc01/src/butil/memory/singleton.h incubator-brpc-0.9.7-rc01/src/butil/memory/singleton_objc.h incubator-brpc-0.9.7-rc01/src/butil/memory/weak_ptr.cc incubator-brpc-0.9.7-rc01/src/butil/memory/weak_ptr.h incubator-brpc-0.9.7-rc01/src/butil/numerics/safe_conversions.h incubator-brpc-0.9.7-rc01/src/butil/numerics/safe_conversions_impl.h incubator-brpc-0.9.7-rc01/src/butil/numerics/safe_math.h incubator-brpc-0.9.7-rc01/src/butil/numerics/safe_math_impl.h incubator-brpc-0.9.7-rc01/src/butil/posix/eintr_wrapper.h incubator-brpc-0.9.7-rc01/src/butil/posix/file_descriptor_shuffle.cc incubator-brpc-0.9.7-rc01/src/butil/posix/file_descriptor_shuffle.h incubator-brpc-0.9.7-rc01/src/butil/posix/global_descriptors.cc incubator-brpc-0.9.7-rc01/src/butil/posix/global_descriptors.h incubator-brpc-0.9.7-rc01/src/butil/strings/latin1_string_conversions.cc incubator-brpc-0.9.7-rc01/src/butil/strings/latin1_string_conversions.h incubator-brpc-0.9.7-rc01/src/butil/strings/nullable_string16.cc incubator-brpc-0.9.7-rc01/src/butil/strings/nullable_string16.h incubator-brpc-0.9.7-rc01/src/butil/strings/safe_sprintf.cc incubator-brpc-0.9.7-rc01/src/butil/strings/safe_sprintf.h incubator-brpc-0.9.7-rc01/src/butil/strings/string16.cc incubator-brpc-0.9.7-rc01/src/butil/strings/string16.h incubator-brpc-0.9.7-rc01/src/butil/strings/string_number_conversions.cc incubator-brpc-0.9.7-rc01/src/butil/strings/string_number_conversions.h incubator-brpc-0.9.7-rc01/src/butil/strings/string_piece.cc incubator-brpc-0.9.7-rc01/src/butil/strings/string_piece.h incubator-brpc-0.9.7-rc01/src/butil/strings/string_split.cc incubator-brpc-0.9.7-rc01/src/butil/strings/string_split.h incubator-brpc-0.9.7-rc01/src/butil/strings/string_tokenizer.h incubator-brpc-0.9.7-rc01/src/butil/strings/string_util.cc incubator-brpc-0.9.7-rc01/src/butil/strings/string_util.h incubator-brpc-0.9.7-rc01/src/butil/strings/string_util_constants.cc incubator-brpc-0.9.7-rc01/src/butil/strings/string_util_posix.h incubator-brpc-0.9.7-rc01/src/butil/strings/stringize_macros.h incubator-brpc-0.9.7-rc01/src/butil/strings/stringprintf.cc incubator-brpc-0.9.7-rc01/src/butil/strings/stringprintf.h incubator-brpc-0.9.7-rc01/src/butil/strings/sys_string_conversions.h incubator-brpc-0.9.7-rc01/src/butil/strings/sys_string_conversions_mac.mm incubator-brpc-0.9.7-rc01/src/butil/strings/sys_string_conversions_posix.cc incubator-brpc-0.9.7-rc01/src/butil/strings/utf_offset_string_conversions.cc incubator-brpc-0.9.7-rc01/src/butil/strings/utf_offset_string_conversions.h incubator-brpc-0.9.7-rc01/src/butil/strings/utf_string_conversion_utils.cc incubator-brpc-0.9.7-rc01/src/butil/strings/utf_string_conversion_utils.h incubator-brpc-0.9.7-rc01/src/butil/strings/utf_string_conversions.cc incubator-brpc-0.9.7-rc01/src/butil/strings/utf_string_conversions.h incubator-brpc-0.9.7-rc01/src/butil/synchronization/cancellation_flag.cc incubator-brpc-0.9.7-rc01/src/butil/synchronization/cancellation_flag.h incubator-brpc-0.9.7-rc01/src/butil/synchronization/condition_variable.h incubator-brpc-0.9.7-rc01/src/butil/synchronization/condition_variable_posix.cc incubator-brpc-0.9.7-rc01/src/butil/synchronization/spin_wait.h incubator-brpc-0.9.7-rc01/src/butil/synchronization/waitable_event.h incubator-brpc-0.9.7-rc01/src/butil/synchronization/waitable_event_posix.cc incubator-brpc-0.9.7-rc01/src/butil/third_party/dmg_fp/README.chromium incubator-brpc-0.9.7-rc01/src/butil/third_party/dmg_fp/dmg_fp.h incubator-brpc-0.9.7-rc01/src/butil/third_party/dmg_fp/dtoa.cc incubator-brpc-0.9.7-rc01/src/butil/third_party/dmg_fp/dtoa_wrapper.cc incubator-brpc-0.9.7-rc01/src/butil/third_party/dmg_fp/float_precision_crash.patch incubator-brpc-0.9.7-rc01/src/butil/third_party/dmg_fp/g_fmt.cc incubator-brpc-0.9.7-rc01/src/butil/third_party/dmg_fp/gcc_64_bit.patch incubator-brpc-0.9.7-rc01/src/butil/third_party/dmg_fp/gcc_warnings.patch incubator-brpc-0.9.7-rc01/src/butil/third_party/dmg_fp/mac_wextra.patch incubator-brpc-0.9.7-rc01/src/butil/third_party/dmg_fp/vs2013-optimization.patch incubator-brpc-0.9.7-rc01/src/butil/third_party/dmg_fp/win_vs2012.patch incubator-brpc-0.9.7-rc01/src/butil/third_party/dynamic_annotations/README.chromium incubator-brpc-0.9.7-rc01/src/butil/third_party/dynamic_annotations/dynamic_annotations.c incubator-brpc-0.9.7-rc01/src/butil/third_party/dynamic_annotations/dynamic_annotations.h incubator-brpc-0.9.7-rc01/src/butil/third_party/icu/README.chromium incubator-brpc-0.9.7-rc01/src/butil/third_party/icu/icu_utf.cc incubator-brpc-0.9.7-rc01/src/butil/third_party/icu/icu_utf.h incubator-brpc-0.9.7-rc01/src/butil/third_party/modp_b64/README.chromium incubator-brpc-0.9.7-rc01/src/butil/third_party/modp_b64/modp_b64.cc incubator-brpc-0.9.7-rc01/src/butil/third_party/modp_b64/modp_b64.h incubator-brpc-0.9.7-rc01/src/butil/third_party/modp_b64/modp_b64_data.h incubator-brpc-0.9.7-rc01/src/butil/third_party/rapidjson/allocators.h incubator-brpc-0.9.7-rc01/src/butil/third_party/rapidjson/document.h incubator-brpc-0.9.7-rc01/src/butil/third_party/rapidjson/encodedstream.h incubator-brpc-0.9.7-rc01/src/butil/third_party/rapidjson/encodings.h incubator-brpc-0.9.7-rc01/src/butil/third_party/rapidjson/filereadstream.h incubator-brpc-0.9.7-rc01/src/butil/third_party/rapidjson/filewritestream.h incubator-brpc-0.9.7-rc01/src/butil/third_party/rapidjson/memorybuffer.h incubator-brpc-0.9.7-rc01/src/butil/third_party/rapidjson/memorystream.h incubator-brpc-0.9.7-rc01/src/butil/third_party/rapidjson/pointer.h incubator-brpc-0.9.7-rc01/src/butil/third_party/rapidjson/prettywriter.h incubator-brpc-0.9.7-rc01/src/butil/third_party/rapidjson/rapidjson.h incubator-brpc-0.9.7-rc01/src/butil/third_party/rapidjson/reader.h incubator-brpc-0.9.7-rc01/src/butil/third_party/rapidjson/rename.patch incubator-brpc-0.9.7-rc01/src/butil/third_party/rapidjson/stringbuffer.h incubator-brpc-0.9.7-rc01/src/butil/third_party/rapidjson/writer.h incubator-brpc-0.9.7-rc01/src/butil/third_party/rapidjson/error/en.h incubator-brpc-0.9.7-rc01/src/butil/third_party/rapidjson/error/error.h incubator-brpc-0.9.7-rc01/src/butil/third_party/rapidjson/internal/biginteger.h incubator-brpc-0.9.7-rc01/src/butil/third_party/rapidjson/internal/diyfp.h incubator-brpc-0.9.7-rc01/src/butil/third_party/rapidjson/internal/dtoa.h incubator-brpc-0.9.7-rc01/src/butil/third_party/rapidjson/internal/ieee754.h incubator-brpc-0.9.7-rc01/src/butil/third_party/rapidjson/internal/itoa.h incubator-brpc-0.9.7-rc01/src/butil/third_party/rapidjson/internal/meta.h incubator-brpc-0.9.7-rc01/src/butil/third_party/rapidjson/internal/pow10.h incubator-brpc-0.9.7-rc01/src/butil/third_party/rapidjson/internal/stack.h incubator-brpc-0.9.7-rc01/src/butil/third_party/rapidjson/internal/strfunc.h incubator-brpc-0.9.7-rc01/src/butil/third_party/rapidjson/internal/strtod.h incubator-brpc-0.9.7-rc01/src/butil/third_party/rapidjson/msinttypes/inttypes.h incubator-brpc-0.9.7-rc01/src/butil/third_party/rapidjson/msinttypes/stdint.h incubator-brpc-0.9.7-rc01/src/butil/third_party/snappy/COPYING incubator-brpc-0.9.7-rc01/src/butil/third_party/snappy/format_description.txt incubator-brpc-0.9.7-rc01/src/butil/third_party/snappy/framing_format.txt incubator-brpc-0.9.7-rc01/src/butil/third_party/snappy/snappy-internal.h incubator-brpc-0.9.7-rc01/src/butil/third_party/snappy/snappy-sinksource.cc incubator-brpc-0.9.7-rc01/src/butil/third_party/snappy/snappy-sinksource.h incubator-brpc-0.9.7-rc01/src/butil/third_party/snappy/snappy-stubs-internal.cc incubator-brpc-0.9.7-rc01/src/butil/third_party/snappy/snappy-stubs-internal.h incubator-brpc-0.9.7-rc01/src/butil/third_party/snappy/snappy.cc incubator-brpc-0.9.7-rc01/src/butil/third_party/snappy/snappy.h incubator-brpc-0.9.7-rc01/src/butil/third_party/superfasthash/README.chromium incubator-brpc-0.9.7-rc01/src/butil/third_party/superfasthash/superfasthash.c incubator-brpc-0.9.7-rc01/src/butil/third_party/symbolize/README.chromium incubator-brpc-0.9.7-rc01/src/butil/third_party/symbolize/config.h incubator-brpc-0.9.7-rc01/src/butil/third_party/symbolize/demangle.cc incubator-brpc-0.9.7-rc01/src/butil/third_party/symbolize/demangle.h incubator-brpc-0.9.7-rc01/src/butil/third_party/symbolize/symbolize.cc incubator-brpc-0.9.7-rc01/src/butil/third_party/symbolize/symbolize.h incubator-brpc-0.9.7-rc01/src/butil/third_party/symbolize/utilities.h incubator-brpc-0.9.7-rc01/src/butil/third_party/symbolize/glog/logging.h incubator-brpc-0.9.7-rc01/src/butil/third_party/symbolize/glog/raw_logging.h incubator-brpc-0.9.7-rc01/src/butil/third_party/valgrind/valgrind.h incubator-brpc-0.9.7-rc01/src/butil/threading/non_thread_safe.h incubator-brpc-0.9.7-rc01/src/butil/threading/non_thread_safe_impl.cc incubator-brpc-0.9.7-rc01/src/butil/threading/non_thread_safe_impl.h incubator-brpc-0.9.7-rc01/src/butil/threading/platform_thread.h incubator-brpc-0.9.7-rc01/src/butil/threading/platform_thread_freebsd.cc incubator-brpc-0.9.7-rc01/src/butil/threading/platform_thread_linux.cc incubator-brpc-0.9.7-rc01/src/butil/threading/platform_thread_mac.mm incubator-brpc-0.9.7-rc01/src/butil/threading/platform_thread_posix.cc incubator-brpc-0.9.7-rc01/src/butil/threading/simple_thread.cc incubator-brpc-0.9.7-rc01/src/butil/threading/simple_thread.h incubator-brpc-0.9.7-rc01/src/butil/threading/thread_checker.h incubator-brpc-0.9.7-rc01/src/butil/threading/thread_checker_impl.cc incubator-brpc-0.9.7-rc01/src/butil/threading/thread_checker_impl.h incubator-brpc-0.9.7-rc01/src/butil/threading/thread_collision_warner.cc incubator-brpc-0.9.7-rc01/src/butil/threading/thread_collision_warner.h incubator-brpc-0.9.7-rc01/src/butil/threading/thread_id_name_manager.cc incubator-brpc-0.9.7-rc01/src/butil/threading/thread_id_name_manager.h incubator-brpc-0.9.7-rc01/src/butil/threading/thread_local.h incubator-brpc-0.9.7-rc01/src/butil/threading/thread_local_posix.cc incubator-brpc-0.9.7-rc01/src/butil/threading/thread_local_storage.cc incubator-brpc-0.9.7-rc01/src/butil/threading/thread_local_storage.h incubator-brpc-0.9.7-rc01/src/butil/threading/thread_local_storage_posix.cc incubator-brpc-0.9.7-rc01/src/butil/threading/thread_restrictions.cc incubator-brpc-0.9.7-rc01/src/butil/threading/thread_restrictions.h incubator-brpc-0.9.7-rc01/src/butil/threading/watchdog.cc incubator-brpc-0.9.7-rc01/src/butil/threading/watchdog.h incubator-brpc-0.9.7-rc01/src/butil/time/clock.cc incubator-brpc-0.9.7-rc01/src/butil/time/clock.h incubator-brpc-0.9.7-rc01/src/butil/time/default_clock.cc incubator-brpc-0.9.7-rc01/src/butil/time/default_clock.h incubator-brpc-0.9.7-rc01/src/butil/time/default_tick_clock.cc incubator-brpc-0.9.7-rc01/src/butil/time/default_tick_clock.h incubator-brpc-0.9.7-rc01/src/butil/time/tick_clock.cc incubator-brpc-0.9.7-rc01/src/butil/time/tick_clock.h incubator-brpc-0.9.7-rc01/src/butil/time/time.cc incubator-brpc-0.9.7-rc01/src/butil/time/time.h incubator-brpc-0.9.7-rc01/src/butil/time/time_mac.cc incubator-brpc-0.9.7-rc01/src/butil/time/time_posix.cc incubator-brpc-0.9.7-rc01/test/aligned_memory_unittest.cc incubator-brpc-0.9.7-rc01/test/allocator_unittest.cc incubator-brpc-0.9.7-rc01/test/at_exit_unittest.cc incubator-brpc-0.9.7-rc01/test/atomicops_unittest.cc incubator-brpc-0.9.7-rc01/test/barrier_closure_unittest.cc incubator-brpc-0.9.7-rc01/test/base64_unittest.cc incubator-brpc-0.9.7-rc01/test/big_endian_unittest.cc incubator-brpc-0.9.7-rc01/test/bits_unittest.cc incubator-brpc-0.9.7-rc01/test/callback_helpers_unittest.cc incubator-brpc-0.9.7-rc01/test/callback_list_unittest.cc incubator-brpc-0.9.7-rc01/test/callback_unittest.cc incubator-brpc-0.9.7-rc01/test/cancelable_callback_unittest.cc incubator-brpc-0.9.7-rc01/test/cancellation_flag_unittest.cc incubator-brpc-0.9.7-rc01/test/cert1.crt incubator-brpc-0.9.7-rc01/test/cert1.key incubator-brpc-0.9.7-rc01/test/cert2.crt incubator-brpc-0.9.7-rc01/test/cert2.key incubator-brpc-0.9.7-rc01/test/condition_variable_unittest.cc incubator-brpc-0.9.7-rc01/test/cpu_unittest.cc incubator-brpc-0.9.7-rc01/test/crash_logging_unittest.cc incubator-brpc-0.9.7-rc01/test/crc32c_unittest.cc incubator-brpc-0.9.7-rc01/test/dir_reader_posix_unittest.cc incubator-brpc-0.9.7-rc01/test/environment_unittest.cc incubator-brpc-0.9.7-rc01/test/file_descriptor_shuffle_unittest.cc incubator-brpc-0.9.7-rc01/test/file_path_unittest.cc incubator-brpc-0.9.7-rc01/test/file_unittest.cc incubator-brpc-0.9.7-rc01/test/file_util_unittest.cc incubator-brpc-0.9.7-rc01/test/guid_unittest.cc incubator-brpc-0.9.7-rc01/test/hash_tables_unittest.cc incubator-brpc-0.9.7-rc01/test/hash_unittest.cc incubator-brpc-0.9.7-rc01/test/jsonout incubator-brpc-0.9.7-rc01/test/lazy_instance_unittest.cc incubator-brpc-0.9.7-rc01/test/leak_tracker_unittest.cc incubator-brpc-0.9.7-rc01/test/linked_list_unittest.cc incubator-brpc-0.9.7-rc01/test/linked_ptr_unittest.cc incubator-brpc-0.9.7-rc01/test/lock_unittest.cc incubator-brpc-0.9.7-rc01/test/logging_unittest.cc incubator-brpc-0.9.7-rc01/test/md5_unittest.cc incubator-brpc-0.9.7-rc01/test/memory_unittest.cc incubator-brpc-0.9.7-rc01/test/memory_unittest_mac.h incubator-brpc-0.9.7-rc01/test/mru_cache_unittest.cc incubator-brpc-0.9.7-rc01/test/multiprocess_func_list.h incubator-brpc-0.9.7-rc01/test/non_thread_safe_unittest.cc incubator-brpc-0.9.7-rc01/test/nullable_string16_unittest.cc incubator-brpc-0.9.7-rc01/test/observer_list_unittest.cc incubator-brpc-0.9.7-rc01/test/platform_thread_unittest.cc incubator-brpc-0.9.7-rc01/test/proc_maps_linux_unittest.cc incubator-brpc-0.9.7-rc01/test/rand_util_unittest.cc incubator-brpc-0.9.7-rc01/test/ref_counted_memory_unittest.cc incubator-brpc-0.9.7-rc01/test/ref_counted_unittest.cc incubator-brpc-0.9.7-rc01/test/safe_numerics_unittest.cc incubator-brpc-0.9.7-rc01/test/safe_sprintf_unittest.cc incubator-brpc-0.9.7-rc01/test/scoped_clear_errno_unittest.cc incubator-brpc-0.9.7-rc01/test/scoped_generic_unittest.cc incubator-brpc-0.9.7-rc01/test/scoped_locale.cc incubator-brpc-0.9.7-rc01/test/scoped_locale.h incubator-brpc-0.9.7-rc01/test/scoped_ptr_unittest.cc incubator-brpc-0.9.7-rc01/test/scoped_temp_dir_unittest.cc incubator-brpc-0.9.7-rc01/test/scoped_vector_unittest.cc incubator-brpc-0.9.7-rc01/test/security_unittest.cc incubator-brpc-0.9.7-rc01/test/sha1_unittest.cc incubator-brpc-0.9.7-rc01/test/shared_memory_unittest.cc incubator-brpc-0.9.7-rc01/test/simple_thread_unittest.cc incubator-brpc-0.9.7-rc01/test/singleton_unittest.cc incubator-brpc-0.9.7-rc01/test/small_map_unittest.cc incubator-brpc-0.9.7-rc01/test/stack_container_unittest.cc incubator-brpc-0.9.7-rc01/test/stack_trace_unittest.cc incubator-brpc-0.9.7-rc01/test/stl_util_unittest.cc incubator-brpc-0.9.7-rc01/test/string16_unittest.cc incubator-brpc-0.9.7-rc01/test/string_number_conversions_unittest.cc incubator-brpc-0.9.7-rc01/test/string_piece_unittest.cc incubator-brpc-0.9.7-rc01/test/string_split_unittest.cc incubator-brpc-0.9.7-rc01/test/string_tokenizer_unittest.cc incubator-brpc-0.9.7-rc01/test/string_util_unittest.cc incubator-brpc-0.9.7-rc01/test/stringize_macros_unittest.cc incubator-brpc-0.9.7-rc01/test/stringprintf_unittest.cc incubator-brpc-0.9.7-rc01/test/sys_info_unittest.cc incubator-brpc-0.9.7-rc01/test/sys_string_conversions_unittest.cc incubator-brpc-0.9.7-rc01/test/test_file_util_linux.cc incubator-brpc-0.9.7-rc01/test/test_switches.cc incubator-brpc-0.9.7-rc01/test/test_switches.h incubator-brpc-0.9.7-rc01/test/thread_checker_unittest.cc incubator-brpc-0.9.7-rc01/test/thread_collision_warner_unittest.cc incubator-brpc-0.9.7-rc01/test/thread_id_name_manager_unittest.cc incubator-brpc-0.9.7-rc01/test/thread_local_storage_unittest.cc incubator-brpc-0.9.7-rc01/test/thread_local_unittest.cc incubator-brpc-0.9.7-rc01/test/time_unittest.cc incubator-brpc-0.9.7-rc01/test/type_traits_unittest.cc incubator-brpc-0.9.7-rc01/test/utf_offset_string_conversions_unittest.cc incubator-brpc-0.9.7-rc01/test/utf_string_conversions_unittest.cc incubator-brpc-0.9.7-rc01/test/version_unittest.cc incubator-brpc-0.9.7-rc01/test/waitable_event_unittest.cc incubator-brpc-0.9.7-rc01/test/watchdog_unittest.cc incubator-brpc-0.9.7-rc01/test/weak_ptr_unittest.cc incubator-brpc-0.9.7-rc01/tools/pprof incubator-brpc-0.9.7-rc01/tools/trackme_server/bugs Best Regards, Von Gosling > On Nov 18, 2019, at 5:59 PM, tan zhongyi <zhongyi....@gmail.com> wrote: > > Ok, we got 3 +1 bindings > > Hi, JB,von and Kevin, can you take a look? Thanks > > > 在 2019/11/18 下午4:39,“JiashunZhu”<zhujiashun2...@gmail.com> 写入: > > +1 binding. > > Bear Jiang <jrjb...@gmail.com> 于2019年11月15日周五 下午3:58写道: > >> +1 binding >> >> I've checked: >> - DISCLAIMER exists >> - NOTICE and LICENSE exist and are correct >> - source files compile correctly from Mac 10.12 >> >> On Thu, Nov 14, 2019 at 10:34 PM James Ge <jge...@gmail.com> wrote: >> >>> +1 binding >>> >>> On Thu, Nov 7, 2019 at 7:02 PM tan zhongyi <zhongyi....@gmail.com> >> wrote: >>> >>>> Ping again。 >>>> >>>> >>>> 在 2019/10/31 上午11:10,“tan zhongyi”<jerry....@apache.org> 写入: >>>> >>>> Hi, jb & kevin, von >>>> >>>> Can you take a look? Thanks >>>> >>>> >>>> >>>> >>>> 在 2019/10/29 下午2:30,“tan zhongyi”<zhongyi....@gmail.com> 写入: >>>> >>>> Hi, guys, >>>> >>>> >>>> >>>> 0.9.7-rc01 is ready for vote, here it is. >>>> >>>> I am pleased to be calling this vote for the release of apache >>>> brpc(incubating) 0.9.7-rc01. >>>> >>>> >>>> The source code can be found at: >>>> >>>> >>>> >>> >> https://dist.apache.org/repos/dist/dev/incubator/brpc/0.9.7-rc01/incubator-brpc-0.9.7-rc01.tar.gz >>>> >>>> >>>> The release candidate has been tagged in GitHub as 0.9.7-rc01, >>>> available here: >>>> >> https://github.com/apache/incubator-brpc/releases/tag/0.9.7-rc01 >>>> >>>> The SHA-512 checksum is: >>>> >>>> >>> >> 0471963a5b75a7ee737f1bde136826e02ef1b267be8125e6e8ecff64fe58fefaa9ddab2ccc51d70b90ccac161b2c761b5e652f32139677532ee27be169add306 >>>> >>>> >>>> >>>> which can be found via: >>>> >>>> >>> >> https://dist.apache.org/repos/dist/dev/incubator/brpc/0.9.7-rc01/incubator-brpc-0.9.7-rc01.tar.gz.sha512 >>>> >>>> >>>> >>>> The signature can be found via: >>>> >>>> >>> >> https://dist.apache.org/repos/dist/dev/incubator/brpc/0.9.7-rc01/incubator-brpc-0.9.7-rc01.tar.gz.asc >>>> >>>> >>>> >>>> KEYS file is available here: >>>> >>>> https://dist.apache.org/repos/dist/dev/incubator/brpc/KEYS >>>> >>>> >>>> >>>> >>>> >>>> [Release Note] >>>> >>>> >>>> >>>> * Health (of a connection) can be checked at rpc-level >>>> * Fix SSL-related compilation issues on Mac >>>> * Support SSL-replacement lib MesaLink >>>> * Support consistent hashing with ketama algo. >>>> * bvar variables can be exported for prometheus services >>>> * String[Multi]Splitter supports '\0' as separator >>>> * Support for bilibili discovery service >>>> * Improved CircuitBreaker >>>> * grpc impl. supports timeout >>>> >>>> >>>> >>>> >>>> >>>> Please vote on releasing this package as: >>>> >>>> Apache brpc(incubating) 0.9.7-rc01 >>>> >>>> >>>> >>>> This vote will be open until “Feb Nov 5 2019 00:00:00 GMT+0800 >>>> (CST)" and >>>> >>>> passes if a majority of at least three +1 Apache brpc IPMC >> votes >>>> are >>>> >>>> cast. >>>> >>>> >>>> >>>> [ ] +1 Release this package >>>> >>>> [ ] 0 I don't feel strongly about it, but don't object >>>> >>>> [ ] -1 Do not release this package because... >>>> >>>> >>>> Checklist for reference: >>>> [ ]Are release files in correct location? >>>> [ ]Do release files have the word incubating in their name? >>>> [ ] Are the digital signature and hashes correct? >>>> [ ] Does DISCLAIMER file exist? >>>> [ ]Do LICENSE and NOTICE files exists? >>>> [ ] Is the LICENSE and NOTICE text correct? >>>> [ ] Is the NOTICE year correct? >>>> [ ] Un-included software dependencies are not mentioned in >>> LICENSE >>>> or NOTICE? >>>> [ ] License information is not mentioned in NOTICE? >>>> Is there any 3rd party code contained inside the release? If >> so: >>>> [ ] Does the software have a compatible license? >>>> [ ] Are all software licenses mentioned in LICENSE? >>>> [ ] Is the full text of the licenses (or pointers to it) in >>>> LICENSE? >>>> Is any of this code Apache licensed? Do they have NOTICE files? >>> If >>>> so: >>>> [ ]Have relevant parts of those NOTICE files been added to this >>>> NOTICE file? >>>> [ ]Do all source files have ASF headers? >>>> [ ] Do the contents of the release match with what's tagged in >>>> version control? >>>> [ ] Are there any unexpected binary files in the release? >>>> [ ] Can you compile from source? Are the instruction clear? >>>> >>>> >>>> >>>> >>>> Anyone can participate in testing and voting, not just >>> committers, >>>> please >>>> >>>> feel free to try out the release candidate and provide your >>> votes. >>>> >>>> Thanks >>>> >>>> >>>> >>>> >>>> >>>> --------------------------------------------------------------------- >>>> To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org >>>> For additional commands, e-mail: dev-h...@brpc.apache.org >>>> >>> >> > > > -- > Jiashun Zhu > --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For additional commands, e-mail: dev-h...@brpc.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For additional commands, e-mail: dev-h...@brpc.apache.org