jamesge commented on a change in pull request #991: Support protocol parsing
order
URL: https://github.com/apache/incubator-brpc/pull/991#discussion_r356976911
##########
File path: src/brpc/global.cpp
##########
@@ -556,7 +575,7 @@ static void GlobalInitializeOrDieImpl() {
NULL, NULL, NULL,
(ConnectionType)(CONNECTION_TYPE_SINGLE|CONNECTION_TYPE_SHORT),
"rtmp" };
- if (RegisterProtocol(PROTOCOL_RTMP, rtmp_protocol) != 0) {
+ if (RegisterProtocol(PROTOCOL_RTMP, rtmp_protocol, order_map) != 0) {
Review comment:
为什么要传完整的一个map？非常奇怪，也无法让其他模块用好这个功能
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org
For additional commands, e-mail: dev-h...@brpc.apache.org
