jamesge commented on a change in pull request #991: Support protocol parsing
order
URL: https://github.com/apache/incubator-brpc/pull/991#discussion_r356976719
##########
File path: src/brpc/input_messenger.cpp
##########
@@ -86,7 +86,7 @@ ParseResult InputMessenger::CutInputMessage(
}
if (m->CreatedByConnect() &&
// baidu_std may fall to streaming_rpc
- (ProtocolType)preferred != PROTOCOL_BAIDU_STD) {
+ strcmp(_handlers[preferred].name, "baidu_std") != 0) {
Review comment:
这个效率不行，这里是hotpath
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org
For additional commands, e-mail: dev-h...@brpc.apache.org
