[GitHub] [incubator-brpc] liumh8 commented on a change in pull request #1128: fix redis args

[GitBox]

liumh8 commented on a change in pull request #1128:
URL: https://github.com/apache/incubator-brpc/pull/1128#discussion_r434985516



##########
File path: src/brpc/policy/redis_protocol.cpp
##########
@@ -189,7 +189,9 @@ ParseResult ParseRedisMessage(butil::IOBuf* source, Socket* 
socket,
         wopt.ignore_eovercrowded = true;
         LOG_IF(WARNING, socket->Write(&sendbuf, &wopt) != 0)
             << "Fail to send redis reply";
-        ctx->arena.clear();
+        if (err != PARSE_ERROR_NOT_ENOUGH_DATA) {
+            ctx->arena.clear();
+        }

Review comment:
       
为什么会每条消息都返回PARSE_ERROR_NOT_ENOUGH_DATA？不会一直都是PARSE_ERROR_NOT_ENOUGH_DATA吧，如果PARSE_ERROR_ABSOLUTELY_WRONG或者PARSE_ERROR_TRY_OTHERS，就会释放了吧




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org
For additional commands, e-mail: dev-h...@brpc.apache.org