[GitHub] [incubator-brpc] zyearn commented on a change in pull request #1128: fix redis args

[GitBox]

zyearn commented on a change in pull request #1128:
URL: https://github.com/apache/incubator-brpc/pull/1128#discussion_r435045025



##########
File path: src/brpc/policy/redis_protocol.cpp
##########
@@ -189,7 +189,9 @@ ParseResult ParseRedisMessage(butil::IOBuf* source, Socket* 
socket,
         wopt.ignore_eovercrowded = true;
         LOG_IF(WARNING, socket->Write(&sendbuf, &wopt) != 0)
             << "Fail to send redis reply";
-        ctx->arena.clear();
+        if (err != PARSE_ERROR_NOT_ENOUGH_DATA) {
+            ctx->arena.clear();
+        }

Review comment:
       第一个请求发了1.5条消息，解析了第一条，第二条解析了一半分配在arena上，之后的请求又只解析了一条完整的，剩下的在arena上，以此往复。




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org
For additional commands, e-mail: dev-h...@brpc.apache.org