liumh8 commented on a change in pull request #1128:
URL: https://github.com/apache/incubator-brpc/pull/1128#discussion_r436583876
##########
File path: src/brpc/redis.cpp
##########
@@ -436,8 +436,9 @@ std::ostream& operator<<(std::ostream& os, const
RedisResponse& response) {
return os;
}
-bool RedisService::AddCommandHandler(const std::string& name,
RedisCommandHandler* handler) {
- std::string lcname = StringToLowerASCII(name);
+bool RedisService::AddCommandHandler(const butil::StringPiece& name,
+ RedisCommandHandler* handler) {
+ std::string lcname = StringToLowerASCII(name.as_string());
Review comment:
StringToLowerASCII不支持StringPiece吧？StringPiece里只有const_iterator，没有iterator。其实这个函数参数用string就好了吧？
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org
For additional commands, e-mail: dev-h...@brpc.apache.org
