jamesge commented on a change in pull request #1128: URL: https://github.com/apache/incubator-brpc/pull/1128#discussion_r436590301
########## File path: src/brpc/redis.cpp ########## @@ -447,9 +448,8 @@ bool RedisService::AddCommandHandler(const std::string& name, RedisCommandHandle return true; } -RedisCommandHandler* RedisService::FindCommandHandler(const std::string& name) const { - std::string lcname = StringToLowerASCII(name); - auto it = _command_map.find(lcname); +RedisCommandHandler* RedisService::FindCommandHandler(const butil::StringPiece& name) const { + auto it = _command_map.find(name.as_string()); Review comment: ok ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For additional commands, e-mail: dev-h...@brpc.apache.org