ZeroLiu2018 commented on code in PR #1806:
URL: https://github.com/apache/incubator-brpc/pull/1806#discussion_r901104640


##########
src/brpc/socket_map.h:
##########
@@ -47,17 +47,18 @@ inline bool operator!=(const ChannelSignature& s1, const 
ChannelSignature& s2) {
 // The following fields uniquely define a Socket. In other word,
 // Socket can't be shared between 2 different SocketMapKeys
 struct SocketMapKey {
-    explicit SocketMapKey(const butil::EndPoint& pt)
-        : peer(pt)
+    explicit SocketMapKey(const butil::EndPoint& pt, const std::string& 
hc_path)
+        : peer(pt), health_check_path(hc_path)
     {}
-    SocketMapKey(const butil::EndPoint& pt, const ChannelSignature& cs)
-        : peer(pt), channel_signature(cs)
+    SocketMapKey(const butil::EndPoint& pt, const std::string& hc_path, const 
ChannelSignature& cs)
+        : peer(pt), health_check_path(hc_path), channel_signature(cs)
     {}
-    SocketMapKey(const ServerNode& sn, const ChannelSignature& cs)
-        : peer(sn), channel_signature(cs)
+    SocketMapKey(const ServerNode& sn, const std::string& hc_path, const 
ChannelSignature& cs)
+        : peer(sn), health_check_path(hc_path), channel_signature(cs)
     {}
 
     ServerNode peer;
+    std::string health_check_path;

Review Comment:
   SocketMap::Insert 的时候,hc_path 作为参数传进来可以吗



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org
For additional commands, e-mail: dev-h...@brpc.apache.org

Reply via email to