ZeroLiu2018 commented on code in PR #1806:
URL: https://github.com/apache/incubator-brpc/pull/1806#discussion_r901113801
##########
src/brpc/socket_map.h:
##########
@@ -47,17 +47,18 @@ inline bool operator!=(const ChannelSignature& s1, const
ChannelSignature& s2) {
// The following fields uniquely define a Socket. In other word,
// Socket can't be shared between 2 different SocketMapKeys
struct SocketMapKey {
- explicit SocketMapKey(const butil::EndPoint& pt)
- : peer(pt)
+ explicit SocketMapKey(const butil::EndPoint& pt, const std::string&
hc_path)
+ : peer(pt), health_check_path(hc_path)
{}
- SocketMapKey(const butil::EndPoint& pt, const ChannelSignature& cs)
- : peer(pt), channel_signature(cs)
+ SocketMapKey(const butil::EndPoint& pt, const std::string& hc_path, const
ChannelSignature& cs)
+ : peer(pt), health_check_path(hc_path), channel_signature(cs)
{}
- SocketMapKey(const ServerNode& sn, const ChannelSignature& cs)
- : peer(sn), channel_signature(cs)
+ SocketMapKey(const ServerNode& sn, const std::string& hc_path, const
ChannelSignature& cs)
+ : peer(sn), health_check_path(hc_path), channel_signature(cs)
{}
ServerNode peer;
+ std::string health_check_path;
Review Comment:
嗯我再看看吧，刚刚本地做了点更改，把 hc_path 仅作为参数传进来。我看看怎么做合适在传上来，谢谢你的 review 和建议（ 太久没写 cpp
了，这次传的代码没咋注意到 引用传递 和 值传递。。。多谢指出
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
