wasphin commented on code in PR #1814:
URL: https://github.com/apache/incubator-brpc/pull/1814#discussion_r912727999
##########
src/brpc/socket.h:
##########
@@ -747,6 +750,11 @@ friend void DereferenceSocket(Socket*);
// Non-zero when health-checking is on.
int _health_check_interval_s;
+ // Default: true,
+ // false when client SocketMap has removed socket.
+ // It can be synchronized via _versioned_ref atomic variable
+ bool _enalbe_health_check;
Review Comment:
不是名字的问题，是我们需要对行为有个合理的定义。如果确定用新加字段的方式控制是否执行健康检查，那么至少需要修正 interval 的注释，更新说明。
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
