chenBright commented on code in PR #1814:
URL: https://github.com/apache/incubator-brpc/pull/1814#discussion_r913349493
##########
src/brpc/socket.h:
##########
@@ -747,6 +750,11 @@ friend void DereferenceSocket(Socket*);
// Non-zero when health-checking is on.
int _health_check_interval_s;
+ // Default: true,
+ // false when client SocketMap has removed socket.
+ // It can be synchronized via _versioned_ref atomic variable
+ bool _enalbe_health_check;
Review Comment:
这样的话，在WaitAndReset里等到引用计数为2之后，需要判断_health_check_interval_s是否为-1。这样处理好像有点奇怪。
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
