Huixxi commented on code in PR #2177: URL: https://github.com/apache/brpc/pull/2177#discussion_r1159208682
########## test/brpc_socket_unittest.cpp: ########## @@ -608,11 +608,11 @@ TEST_F(SocketTest, app_level_health_check) { for (int i = 0; i < 4; ++i) { // although ::connect would succeed, the stall in hc_service makes - // the health check rpc fail. + // the health check rpc overtime but not fail. Review Comment: 这里的备注需要修改一下 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For additional commands, e-mail: dev-h...@brpc.apache.org