wwbmmm commented on code in PR #2177:
URL: https://github.com/apache/brpc/pull/2177#discussion_r1168292598
##########
src/brpc/controller.cpp:
##########
@@ -719,6 +719,37 @@ inline bool does_error_affect_main_socket(int error_code) {
error_code == EINVAL/*returned by connect "0.0.0.1"*/;
}
+inline void maybe_block_server(int error_code, Controller* cntl,
SharedLoadBalancer* lb, SocketId sock) {
+ if (!does_error_affect_main_socket(error_code)) {
Review Comment:
因为这个函数最终的动作是SetFailed main socket，所以要先检查一下错误号是否满足影响main socket 的条件
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org
For additional commands, e-mail: dev-h...@brpc.apache.org
