chenBright commented on code in PR #3323:
URL: https://github.com/apache/brpc/pull/3323#discussion_r3338290967
##########
.github/workflows/ci-linux.yml:
##########
@@ -214,10 +220,19 @@ jobs:
cat config.mk
cd test
make NEED_GPERFTOOLS=0 -j ${{env.proc_num}}
+ - name: install redis-server and mysql-server
+ run: |
+ sudo apt-get update
+ sudo apt-get install -y redis-server mysql-server
+ redis-server --version
+ mysqld --version
- name: run tests
run: |
cd test
- sh ./run_tests.sh
+ # brpc_redis_unittest forks a real redis-server and waits a fixed 50ms
before
+ # connecting; under ASan redis starts too slowly, so the redis client
tests are
+ # flaky here (connection refused). Skip them in ASan; they run in
clang-unittest.
+ GTEST_FILTER='-RedisTest.*' sh ./run_tests.sh
clang-unittest-bazel-with-babylon-and-new-pb:
Review Comment:
Do clang-unittest-bazel-with-babylon-and-new-pb, clang-unittest-with-bazel
and gcc-unittest-with-bazel also require Redis server to be installed?
##########
.github/workflows/ci-linux.yml:
##########
@@ -196,6 +196,12 @@ jobs:
cat config.mk
cd test
make -j ${{env.proc_num}}
+ - name: install redis-server and mysql-server
Review Comment:
You can refer to install-essential-dependencies and add an action to install
the Redis server and MySQL server.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
