rajvarun77 commented on PR #3323: URL: https://github.com/apache/brpc/pull/3323#issuecomment-4608587696
Addressed the review feedback: - **Install location** (@chenBright): moved the `redis-server` / `mysql-server` install into the `install-essential-dependencies` action and removed the bespoke per-job install steps, so every job that brings up dependencies has the servers available. - **ASan filter** (@Copilot): narrowed `GTEST_FILTER` to exclude only the five Redis client tests that race on the forked server (`sanity`, `keys_with_spaces`, `incr_and_decr`, `by_components`, `auth`); the codec/service tests still run under ASan. - **mysql-server**: pre-installed intentionally for the in-progress MySQL protocol support (#2093), so the servers are already in place when those tests land. Re-validated end-to-end on my fork — all Linux jobs green, including `clang-unittest` (runs the live Redis tests) and `clang-unittest-asan` (skips only the five racy ones): https://github.com/rajvarun77/brpc/actions/runs/26858989158 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
