darion-yaphet opened a new pull request, #3385:
URL: https://github.com/apache/brpc/pull/3385
• Remove redundant pthread linkage from protoc-gen-mcpack targets and quiet
compiler warnings from unused rpcz/couchbase code paths and non-x86 iobuf
builds.
### What problem does this PR solve?
Issue Number: resolve
Problem Summary:
This PR cleans up redundant build configuration and compiler warning
sources. `protoc-gen-mcpack` already links through the configured
dynamic/static brpc target and
dynamic libraries, so the explicit `pthread` linkage is unnecessary. A few
warning-only code paths also produced noise from unused rpcz/couchbase symbols
and the non-
x86 iobuf fallback warning.
### What is changed and the side effects?
Changed:
- Removed explicit `pthread` linkage from `protoc-gen-mcpack` CMake
targets.
- Removed an unused `span_type_str` block from rpcz annotation printing.
- Marked `DEFAULT_VBUCKET_COUNT` as `[[maybe_unused]]`.
- Removed the non-x86_64 `#warning` from iobuf fallback code.
- Ensured `src/brpc/couchbase.cpp` ends with a newline.
Side effects:
- Performance effects: None expected.
- Breaking backward compatibility: None expected.
---
### Check List:
- Please make sure your changes are compilable.
- When providing us with a new feature, it is best to add related tests.
- Please follow [Contributor Covenant Code of
Conduct](https://github.com/apache/brpc/blob/master/CODE_OF_CONDUCT.md).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
