Copilot commented on code in PR #3385:
URL: https://github.com/apache/brpc/pull/3385#discussion_r3585399062
##########
src/brpc/couchbase.cpp:
##########
@@ -46,7 +46,7 @@ namespace brpc {
// Couchbase protocol constants
namespace {
[[maybe_unused]] constexpr uint32_t APPLE_VBUCKET_COUNT = 64;
-constexpr uint32_t DEFAULT_VBUCKET_COUNT = 1024;
+[[maybe_unused]] constexpr uint32_t DEFAULT_VBUCKET_COUNT = 1024;
constexpr int CONNECTION_ID_SIZE = 33;
Review Comment:
`[[maybe_unused]]` is a C++17 attribute, but the project defaults to
`BRPC_CXX_STANDARD 11` in CMake. To keep C++11 compatibility while still
silencing unused-constant warnings, prefer the existing `ALLOW_UNUSED` macro
(available via `butil/macros.h`).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
