Felix-Gong commented on PR #3390: URL: https://github.com/apache/brpc/pull/3390#issuecomment-4999602259
## Review Responses Replies to all5 Copilot review comments (comments are on the pre-rebase commit, so replying here): ### 1. BUILD.bazel: `modp_b64_rvv.cc` does not exist **Fixed.** Removed `modp_b64_rvv.cc` from `BUTIL_SRCS` — it was inadvertently included from a prior PR (#3388) and does not belong in this change. ### 2. string_piece.h: Missing `BUTIL_EXPORT` **Fixed.** Added `BUTIL_EXPORT` to the `rvv_memcmp` declaration to ensure proper symbol visibility in shared library builds. ### 3. string_compare_rvv.cc: Return value semantics **Fixed.** Changed to `return static_cast<int>(src1[first]) - static_cast<int>(src2[first]);` which matches glibc `memcmp` semantics and preserves the byte-difference contract expected by `traits_type::compare`. ### 4. string_compare_rvv.cc: NULL vs nullptr **Addressed.** `rvv_memchr` has been removed from this PR and will be added in a follow-up PR with proper `StringPiece::find` dispatch. The doc comment and implementation will be aligned in that PR. ### 5. rvv_memchr has no call sites **Agreed.** `rvv_memchr` has been removed from this PR. It will be reintroduced in a follow-up PR that also wires the dispatch into `StringPiece::find(char)`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
