Felix-Gong commented on code in PR #3390:
URL: https://github.com/apache/brpc/pull/3390#discussion_r3600788927
##########
src/butil/strings/string_piece.h:
##########
@@ -43,6 +43,12 @@
namespace butil {
+// RVV-accelerated byte comparison and search (implemented in
string_compare_rvv.cc)
+#if defined(__riscv) && defined(__riscv_vector)
+int rvv_memcmp(const void* p1, const void* p2, size_t n);
+const void* rvv_memchr(const void* s, int c, size_t n);
+#endif
Review Comment:
Fixed. Added BUTIL_EXPORT to the rvv_memcmp declaration to ensure proper
symbol visibility in shared library builds.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
