zchuango commented on PR #3428: URL: https://github.com/apache/brpc/pull/3428#issuecomment-5585250485
@wwbmmm Addressed the URMA-related Copilot review findings in fe6ea6f3: - Route writes through URMA only after negotiation reaches URMA_ON; TCP remains in use while the state is UNKNOWN. - Replace the non-portable pthread_t reinterpret cast with std::hash<pthread_t>. - Use GFLAGS_NAMESPACE::FlagSaver in the handshake-version test. - Adapt UrmaEndpoint to the current per-stream InputMessengerProcessor model: URMA completions use a dedicated STREAM_URMA_JETTY processor, while fallback bytes return to the TCP fd processor. - Clarify the dedicated transport poller comment for RDMA/UBRING/URMA. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
