wwbmmm commented on code in PR #3428:
URL: https://github.com/apache/brpc/pull/3428#discussion_r3958980567
##########
src/brpc/input_messenger_processor.cpp:
##########
@@ -15,279 +15,286 @@
// specific language governing permissions and limitations
// under the License.
-#include "butil/logging.h"
-#include "butil/binary_printer.h"
-#include "bthread/unstable.h"
-#include "brpc/options.pb.h"
-#include "brpc/transport.h"
#include "brpc/input_messenger_processor.h"
#include "brpc/input_messenger.h"
+#include "brpc/options.pb.h"
+#include "brpc/transport.h"
+#include "bthread/unstable.h"
+#include "butil/binary_printer.h"
+#include "butil/logging.h"
+
namespace brpc {
DECLARE_uint64(max_body_size);
-const size_t MSG_SIZE_WINDOW = 10; // Take last so many message into stat.
+const size_t MSG_SIZE_WINDOW = 10; // Take last so many message into stat.
const size_t MIN_ONCE_READ = 4096;
const size_t MAX_ONCE_READ = 524288;
-static const char* StreamTypeName(InputMessengerProcessor::StreamType type) {
- switch (type) {
- case InputMessengerProcessor::STREAM_NONE: return "none";
- case InputMessengerProcessor::STREAM_TCP_FD: return "tcp_fd";
- case InputMessengerProcessor::STREAM_RDMA_QP: return "rdma_qp";
- }
- return "unknown";
+static const char *StreamTypeName(InputMessengerProcessor::StreamType type) {
+ switch (type) {
+ case InputMessengerProcessor::STREAM_NONE:
+ return "none";
+ case InputMessengerProcessor::STREAM_TCP_FD:
+ return "tcp_fd";
+ case InputMessengerProcessor::STREAM_RDMA_QP:
+ return "rdma_qp";
+ case InputMessengerProcessor::STREAM_URMA_JETTY:
+ return "urma_jetty";
+ }
+ return "unknown";
}
-InputMessengerProcessor::ParsingStreamGuard::ParsingStreamGuard(Socket*
socket, StreamType type)
+InputMessengerProcessor::ParsingStreamGuard::ParsingStreamGuard(Socket *socket,
Review Comment:
don't change these formats
##########
src/brpc/input_messenger.cpp:
##########
@@ -15,35 +15,33 @@
// specific language governing permissions and limitations
// under the License.
-
-#include <gflags/gflags.h>
-#include "butil/fd_guard.h" // fd_guard
-#include "butil/logging.h" // CHECK
-#include "butil/time.h" // cpuwide_time_us
-#include "butil/fd_utility.h" // make_non_blocking
-#include "bthread/bthread.h" // bthread_start_background
-#include "bthread/unstable.h" // bthread_flush
-#include "bvar/bvar.h" // bvar::Adder
-#include "brpc/options.pb.h" // ProtocolType
-#include "brpc/reloadable_flags.h" // BRPC_VALIDATE_GFLAG
-#include "brpc/protocol.h" // ListProtocols
-#include "brpc/rdma/rdma_endpoint.h"
#include "brpc/input_messenger.h"
+#include "brpc/options.pb.h" // ProtocolType
+#include "brpc/protocol.h" // ListProtocols
+#include "brpc/rdma/rdma_endpoint.h"
+#include "brpc/reloadable_flags.h" // BRPC_VALIDATE_GFLAG
#include "brpc/transport_factory.h"
+#include "bthread/bthread.h" // bthread_start_background
+#include "bthread/unstable.h" // bthread_flush
+#include "butil/fd_guard.h" // fd_guard
+#include "butil/fd_utility.h" // make_non_blocking
+#include "butil/logging.h" // CHECK
+#include "butil/time.h" // cpuwide_time_us
+#include "bvar/bvar.h" // bvar::Adder
+#include <gflags/gflags.h>
+
namespace brpc {
-InputMessenger* g_messenger = nullptr;
+InputMessenger *g_messenger = nullptr;
Review Comment:
There's no need to change these formats
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
